Repository navigation
London | 26-ITP-Sep | Chandramani Gaire | Sprint 2 | Coursework/sprint 3 implement and rewrite - #1682
Open
gaireprakash20-ops wants to merge 22 commits into
Conversation
…ator combinations
gaireprakash20-ops
added
📅 Sprint 2
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Oct 15, 2026
| return false; | ||
| } | ||
|
|
||
| if (numerator < 0) { |
There was a problem hiding this comment.
Good job handling the negative values, however is there an easy way of handling negative values?
Think about which built-in function can be used for this scenario.
|
|
||
| if (value === "A") { | ||
| return 11; | ||
| } else if (value === "J") { |
There was a problem hiding this comment.
instead of checking each of the values between J, Q & K in separate else if statements, would it be better to do it in a single statement since all of them return the same result?
hey-hammad
added
Reviewed
gaireprakash20-ops
added
Needs Review
hey-hammad
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1059
Changelist
I worked as per the module instructions and implemented and tested the code.
Questions
I was a bit confused about whether I should delete the file where I spent my initial learning time with JavaScript.